[Capture] handle grad and jacobian #2078
Open
+368
−195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Oct 1, 2025
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2078 +/- ##
==========================================
- Coverage 97.43% 97.42% -0.02%
==========================================
Files 92 92
Lines 10613 10643 +30
Branches 998 1001 +3
==========================================
+ Hits 10341 10369 +28
Misses 214 214
- Partials 58 60 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
albi3ro
added a commit
that referenced
this pull request
Oct 17, 2025
**Context:** When updating tests for #2078 , I was getting weird failures on this test: https://github.com/PennyLaneAI/catalyst/blob/5eec7c770fc5fd1d5c5a9c03124db3967de8769d/frontend/test/pytest/test_gradient.py#L757 Basically what was happening was that the conversion of the target jaxpr was reordering the consts. So we need to use the consts for the *new jaxpr*, not the *input jaxpr*. **Description of the Change:** In all relevant translation steps, we pull the consts from the new jaxpr, not the original inputs. **Benefits:** Get correct results without errors. **Possible Drawbacks:** I didn't test all the other control flow primitives that might have the same issue, because I don't know how to trigger this is other cases. **Related GitHub Issues:** [sc-101609]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Handles the
gradprimitive from pennylane and adds a lowering for it.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-100560]